handle ports race condition by returning 3000 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #40 This is a very simple to fix to the problem with ports where it will occaisonally throw an error: - hoodiehq-archive/node-ports#4 The fix is to catch the error and use port 3000. Not great, but should handle some cases where this was a problem. An alternate fix to try would be to try fetching the port again, probably in a loop (with some limit), in hopes of getting a value from ports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #40
This is a very simple to fix to the problem with ports where it
will occaisonally throw an error:
The fix is to catch the error and use port 3000. Not great, but should
handle some cases where this was a problem.
An alternate fix to try would be to try fetching the port again, probably
in a loop (with some limit), in hopes of getting a value from ports.