fix: Make CloudEvent data field immutable and enumerable #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSanetra
force-pushed
the
make-cloudevent-comparable
branch
from
684e5cf to
02e8229
Compare
lance
reviewed
Oct 31, 2022
Member
lance
left a comment
lance
left a comment
There was a problem hiding this comment.
@PSanetra thanks for this contribution! The atob function does not exist in Node.js LTS prior to version 16. Could you please add atob to dependencies and @types/atob to the dev-dependencies section, and add an import statement in validation.ts? This should get CI passing.
….keys() (cloudevents#515) Signed-off-by: Philip Sanetra <[email protected]>
PSanetra
force-pushed
the
make-cloudevent-comparable
branch
from
02e8229 to
69b2c6e
Compare
Contributor
Author
|
@lance I have changed the code to support node.js runtime and browser runtime without a additional dependency. |
lholmquist
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Object.keys()andObject.entries()datafield anymore ifdata_base64is set to comply with the JSON format spec 3.1.1Out of this follows that the presence of the data and data_base64 members is mutually exclusive in a JSON serialized CloudEvent.Fixes #515