fix: Emitter should not extend EventEmitter #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies Emitter so that it does not directly extend the Node.js EventEmitter class. Instead, it holds a singleton instance of an EventEmitter but is not an instance of EventEmitter itself. This commit also updates the typescript example to use a modern version of @types/node and typescript. Finally there are a few minor formatting changes picked up by eslint. Fixes: #385 Signed-off-by: Lance Ball <[email protected]>
lance
added
type/fix
grant
approved these changes
Feb 25, 2021
loopingz
reviewed
Feb 25, 2021
Contributor
loopingz
left a comment
loopingz
left a comment
There was a problem hiding this comment.
A part from the 2 small comments, it looks good to me.
Thanks
lholmquist
approved these changes
Feb 25, 2021
loopingz
approved these changes
Feb 25, 2021
Signed-off-by: Lance Ball <[email protected]>
loopingz
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies Emitter so that it does not directly extend the Node.js
EventEmitter class. Instead, it holds a singleton instance of an EventEmitter
but is not an instance of EventEmitter itself.
This commit also updates the typescript example to use a modern version of
@types/node and typescript.
Finally there are a few minor formatting changes picked up by eslint.
@loopingz if you have a chance to review this, that would be great. Thanks!
Fixes: #385
Signed-off-by: Lance Ball [email protected]