lib(Constants): expose constants in a more intuitive way #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Constants can now be accessed more easily from the top level import/require fixes cloudevents#298 Signed-off-by: Lucas Holmquist <[email protected]>
lance
approved these changes
Aug 3, 2020
Member
lance
left a comment
lance
left a comment
There was a problem hiding this comment.
LGTM. What do you think about using Constants instead? No particular reason, I just think it looks nicer.
Contributor
Author
Not sure what you mean |
Member
|
I mean export |
grant
approved these changes
Aug 3, 2020
Contributor
Author
Yea, i like that. let me turn this into a draft so i can make the change |
helio-frota
approved these changes
Aug 3, 2020
Contributor
Author
|
I think i might just merge it like it is, using the all caps version. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lucas Holmquist [email protected]
Proposed Changes
This change exposes the
Constantsfrom the "index" so a user no longer has to path into the dist folder. I believe this was the original way to do it before the Typescript re-writeDescription