fix: ensure that event data can be an array, number, boolean or null #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schema incorrectly limits data values to only object and string. This is incorrect, since JSON can be an array or a single number as well. Fixes: cloudevents#280 Signed-off-by: Lance Ball <[email protected]>
lance
added
spec/0.3
lance
requested review from
danbev,
fabiojose and
lholmquist
and removed request for
a team
Signed-off-by: Lance Ball <[email protected]>
lance
changed the title
lholmquist
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The schema incorrectly limits data values to only object and string. This is
incorrect, since JSON can be an array, boolean, null or a single number as well.
This changes the schemas for both 0.3 and 1.0 events and adds test cases.
Description
Signed-off-by: Lance Ball [email protected]