lib: remove specversion from the attributes in receiver.accept() #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt()
The `HTTPReceiver` class' `accept()` method should not have a typescript
type designation of `{ specversion: string }` for the `body` parameter
because the event could (and often is) in binary form, which means that
the `specversion` property won't be there.
This commit changes the method signature to:
`accept(headers: {}, body: {}) : CloudEvent`
Signed-off-by: Lance Ball <[email protected]>
lance
added
type/fix
lance
requested review from
danbev,
grant and
helio-frota
and removed request for
a team
lance
changed the title
Signed-off-by: Lance Ball <[email protected]>
lholmquist
approved these changes
Jun 4, 2020
grant
approved these changes
Jun 4, 2020
helio-frota
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HTTPReceiverclass'accept()method should not have a typescripttype designation of
{ specversion: string }for thebodyparameterbecause the event could be (and often is) in binary form, which means that
the
specversionproperty won't be there.This commit changes the method signature to:
accept(headers: {}, body: {}) : CloudEventSigned-off-by: Lance Ball [email protected]