Add Monitoring roles #174
Merged
Add Monitoring roles #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rsuplina <[email protected]>
jimright
added
the
enhancement
jimright
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Hi @rsuplina,
This looks good. Just have a few comments and suggestions.
Also, have you considered adding a role for blackbox exporter? This might be useful for monitoring of HTTP endpoints of public and private cloud environments?
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
added
validated
jimright
requested changes
Jan 16, 2024
|
|
||
| - job_name: "node_exporter" | ||
| static_configs: | ||
| - targets: ['localhost:9100'] No newline at end of file |
There was a problem hiding this comment.
Should this target url be parameterized and derived from the nodes where the node_exporter is installed?
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
added
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains 3 monitoring roles: