Don't run GPC VPC discovery tasks when the subnet was already specified. #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chusopr
force-pushed
the
gcp-vpc-optional-discovery
branch
from
1fe3976 to
9fb9712
Compare
github-actions
bot
added
validated
jimright
added
the
enhancement
Signed-off-by: Jesus Perez Rey <[email protected]>
chusopr
force-pushed
the
gcp-vpc-optional-discovery
branch
from
9fb9712 to
9e05f69
Compare
github-actions
bot
added
validated
jimright
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VPC network and subnet discovery tasks that run in
roles/platform/tasks/initialize_gcp.ymlmay require additional privileges and are only required to find a subnet to deploy to when not specified. When the subnet is already specified ininfra.gcp.vpc.subnet_idthose tasks are not required.This PR skips those tasks when the subnet is already specified. I needed it for a project where listing GCP subnets was not allowed, so it was already tested.
I also tested that it still works as before when you don't provide a subnet.