Skip to content

Add GCP region zones to CDP Env creation #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2023
Merged

Add GCP region zones to CDP Env creation #143

merged 2 commits into from
Jun 28, 2023

Conversation

@wmudge
Copy link
Member

@wmudge wmudge commented Jun 26, 2023

@wmudge wmudge added the enhancement MINOR - New feature or enhancement in the CHANGELOG label Jun 26, 2023
@wmudge wmudge requested a review from a team June 26, 2023 22:56
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Jun 26, 2023
jimright
jimright requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wmudge - I have tested this with and without AZs specified and this all looks good, apart from my comment about the missing parentheses.

Note that I have not been able to test that a CDP environment & DL are created in the case where AZs are specified as this functionality is not yet available. However confirmed that the zones parameter is populated correctly.

@wmudge
Fix ternary check of AZ array
d36aa68 
Signed-off-by: Webster Mudge <[email protected]>
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Jun 27, 2023
@wmudge wmudge requested a review from jimright June 27, 2023 14:56
jimright
jimright approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@wmudge wmudge merged commit 14c904b into cloudera-labs:devel Jun 28, 2023
@wmudge wmudge deleted the feature/gcp-availability-zones branch June 28, 2023 19:25
wmudge added a commit to wmudge/cloudera.exe that referenced this pull request Aug 12, 2025
@wmudge
Add analytics to API documents (cloudera-labs#143)
3d08f7d 
Signed-off-by: Webster Mudge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimright jimright jimright approved these changes

Assignees

No one assigned

Labels

enhancement MINOR - New feature or enhancement in the CHANGELOG validated The pull request has passed the prechecks

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wmudge @jimright