Allow skipping of GCP Service and IAM management #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les, services, and policies for the user. These commands fail if the user does not have permission to change that setting, whether already enabled/created or not Added env.gcp.manage_identities to control deploy and teardown of GCP credentials, identities and roles. Defaults to True to match existing behavior Added env.gcp.auto_enable_services to control enabling of required GCP services for CDP. Defaults to True to match existing behavior Signed-off-by: Daniel Chaffelson <[email protected]>
Chaffelson
force-pushed
the
gcp_skip_identities
branch
from
4bdabc1 to
bff64c8
Compare
jimright
requested changes
Oct 11, 2022
There was a problem hiding this comment.
@Chaffelson - Apart from the leftover pause mentioned in my comment above, this looks good. Happy to approve once that is removed.
Testing steps:
- Confirmed that the existing behaviour is maintained when these options are not specified;
- Confirmed that
auto_enable_servicesskips/executes the required code blocks as expected (not able to test service enablement as all services were already enabled) - Confirmed that
manage_identitiesskips/executes the required code blocks as expected.
Removed leftover pause from debugging Signed-off-by: Daniel Chaffelson <[email protected]>
Chaffelson
force-pushed
the
gcp_skip_identities
branch
from
52cd198 to
95a56d6
Compare
chusopr
pushed a commit
to bluemetrix-com/cloudera.exe
that referenced
this pull request
Dec 5, 2022
* Add options to control whether Ansible will manage GCP identities, roles, services, and policies for the user. These commands fail if the user does not have permission to change that setting, whether already enabled/created or not Added env.gcp.manage_identities to control deploy and teardown of GCP credentials, identities and roles. Defaults to True to match existing behavior Added env.gcp.auto_enable_services to control enabling of required GCP services for CDP. Defaults to True to match existing behavior * Update setup_gcp_authz.yml * Removed leftover pause from debugging Signed-off-by: Daniel Chaffelson <[email protected]>
wmudge
added a commit
to wmudge/cloudera.exe
that referenced
this pull request
Aug 12, 2025
Signed-off-by: Webster Mudge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options to control whether Ansible will manage GCP identities, roles, services, and policies for the user. These commands fail if the user does not have permission to change that setting, whether already enabled/created or not, and typically BYOI will already have these created by a Cloud Admin team.
Added env.gcp.manage_identities to control deploy and teardown of GCP credentials, identities and roles. Defaults to True to match existing behavior.
Added env.gcp.auto_enable_services to control enabling of required GCP services for CDP. Defaults to True to match existing behavior
Signed-off-by: Daniel Chaffelson [email protected]