Skip to content

Change 'tls' parameter to 'auto_tls' #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

Change 'tls' parameter to 'auto_tls' #285

merged 2 commits into from
May 19, 2025

Conversation

@wmudge
Copy link
Member

@wmudge wmudge commented May 15, 2025

Due to collision with existing TLS verification parameters

@wmudge
Change 'tls' parameter to 'auto_tls' due to collision with existing T…
192ec88 
…LS verification parameters

Signed-off-by: Webster Mudge <[email protected]>
@wmudge wmudge added this to the Release 4.5.0 milestone May 15, 2025
@wmudge wmudge requested a review from a team May 15, 2025 22:44
@wmudge wmudge added the bug POINT - Bugfix entry in the CHANGELOG label May 15, 2025
@github-actions github-actions bot added the validated The pull request has passed the prechecks label May 15, 2025
jimright
jimright requested changes May 19, 2025
View reviewed changes
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter also needs to be changed in the documentation block

@github-actions github-actions bot removed the validated The pull request has passed the prechecks label May 19, 2025
@wmudge wmudge requested a review from jimright May 19, 2025 16:51
@github-actions github-actions bot added the validated The pull request has passed the prechecks label May 19, 2025
jimright
jimright approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@wmudge wmudge merged commit 123da77 into cloudera-labs:devel May 19, 2025
7 checks passed
@wmudge wmudge deleted the update/fix-tls-name-collision branch May 29, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimright jimright jimright approved these changes

Assignees

No one assigned

Labels

bug POINT - Bugfix entry in the CHANGELOG validated The pull request has passed the prechecks

Milestone

Release 5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@wmudge @jimright