Skip to content

Remove invalid get_host_ref() #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Remove invalid get_host_ref() #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions plugins/module_utils/role_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,34 @@ def create_mgmt_role_model(
mgmt_role = ApiRole(type=str(role_type).upper())

# Host assignment
host_ref = get_host_ref(api_client, hostname, host_id)
if hostname:
host_ref = next(
(
h
for h in HostsResourceApi(api_client).read_hosts().items
if h.hostname == hostname
),
None,
)
elif host_id:
try:
host_ref = HostsResourceApi(api_client).read_host(host_id)
except ApiException as ex:
if ex.status != 404:
raise ex
else:
host_ref = None
else:
raise RoleException("Specify either 'hostname' or 'host_id'")

if host_ref is None:
raise RoleHostNotFoundException(
f"Host not found: hostname='{hostname}', host_id='{host_id}'"
)
else:
mgmt_role.host_ref = host_ref
mgmt_role.host_ref = ApiHostRef(
host_id=host_ref.host_id, hostname=host_ref.hostname
)

# Role override configurations
if config:
Expand Down
Loading