Add cm_autotls module #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimright
added
the
enhancement
github-actions
bot
added
validated
wmudge
requested changes
Feb 25, 2025
plugins/modules/cm_autotls.py
Outdated
| ApiConfig, | ||
| ) | ||
|
|
||
| ANSIBLE_METADATA = { |
plugins/modules/cm_autotls.py
Outdated
| force: | ||
| description: | ||
| - Forces enabling Auto-TLS even if it is already determined to be enabled. | ||
| - Applicable only when I(state) is C(true). |
There was a problem hiding this comment.
Update to the current best practices for markup: https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#semantic-markup-within-module-documentation
plugins/modules/cm_autotls.py
Outdated
| if self.state == "present": | ||
|
|
||
| # Enable AutoTLS if not already enabled | ||
| if existing in [None, "NONE"] or self.force: |
There was a problem hiding this comment.
plugins/modules/cm_autotls.py
Outdated
| # # Initialize the return values | ||
| self.cm_config = [] | ||
| self.changed = False | ||
| self.diff = {} |
There was a problem hiding this comment.
|
|
||
|
|
||
| @pytest.fixture | ||
| def conn(): |
There was a problem hiding this comment.
Update to use the current pytest fixtures: https://github.com/cloudera-labs/cloudera.cluster/blob/devel/tests/unit/plugins/modules/cm_service/test_cm_service.py#L41
jimright
force-pushed
the
feature/autotls_module
branch
from
d8e719f to
eb97439
Compare
github-actions
bot
removed
the
validated
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
jimright
force-pushed
the
feature/autotls_module
branch
from
771e567 to
f21b851
Compare
wmudge
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.