Skip to content

Conversation

@rhill-cldr
Copy link
Contributor

Adds a script to enable devenv test which can also be used independently.

@wmudge wmudge requested a review from a team December 4, 2024 15:35
@wmudge wmudge added the enhancement MINOR - New feature or enhancement entry in the CHANGELOG label Dec 4, 2024
@wmudge wmudge added this to the Release 4.5.0 milestone Dec 4, 2024
@wmudge
Copy link
Member

wmudge commented Dec 4, 2024

Hi Ryan! Your commits need DCO sign off. Thx!

@wmudge wmudge self-requested a review December 5, 2024 14:27
@wmudge
Copy link
Member

wmudge commented Dec 5, 2024

Hi @rhill-cldr, can you tackle the outstanding checks? DCO still not there (need to add an explicit Sign-off in your commits; need to run pre-commit)

@github-actions github-actions bot added the validated The pull request has passed the prechecks label Dec 5, 2024
Signed-off-by: Ryan Hill <[email protected]>
@github-actions github-actions bot removed the validated The pull request has passed the prechecks label Dec 5, 2024
Signed-off-by: Ryan Hill <[email protected]>
Signed-off-by: Ryan Hill <[email protected]>
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Dec 10, 2024
mkdir -p .ansible/collections/ansible_collections/cloudera/cluster
git archive $(git rev-parse --abbrev-ref HEAD) | tar -x -C .ansible/collections/ansible_collections/cloudera/cluster
(cd .ansible/collections/ansible_collections/cloudera/cluster && pytest)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an empty line to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two empty lines :)

Run pre-commit run -a

@wmudge wmudge merged commit 87fa43f into cloudera-labs:devel Mar 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement MINOR - New feature or enhancement entry in the CHANGELOG validated The pull request has passed the prechecks

Development

Successfully merging this pull request may close these issues.

2 participants