Skip to content

Add Host Module #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 6, 2024
Merged

Add Host Module #218

merged 6 commits into from
May 6, 2024

Conversation

@rsuplina
Copy link
Contributor

No description provided.

@rsuplina
Add Host Module
72b3783 
Signed-off-by: rsuplina <[email protected]>
@rsuplina rsuplina added the enhancement MINOR - New feature or enhancement entry in the CHANGELOG label Apr 10, 2024
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Apr 10, 2024
@rsuplina
Add Host_Info module
8f12885 
Signed-off-by: rsuplina <[email protected]>
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Apr 10, 2024
@rsuplina rsuplina requested a review from wmudge April 10, 2024 17:43
wmudge
wmudge requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also look at the return values from ApiHost and dereference some of the values like in service and service_role.

@rsuplina
Add requested changes
d6e200e 
Signed-off-by: rsuplina <[email protected]>
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Apr 24, 2024
@rsuplina
Add Host_info updates
33e50b6 
Signed-off-by: rsuplina <[email protected]>
@github-actions github-actions bot removed the validated The pull request has passed the prechecks label Apr 24, 2024
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Apr 24, 2024
wmudge
wmudge requested changes May 3, 2024
View reviewed changes
@rsuplina
Add required changes
c0ef3da 
Signed-off-by: rsuplina <[email protected]>
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels May 3, 2024
@wmudge wmudge merged commit 49ba400 into cloudera-labs:devel May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmudge wmudge wmudge approved these changes

Assignees

No one assigned

Labels

enhancement MINOR - New feature or enhancement entry in the CHANGELOG validated The pull request has passed the prechecks

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rsuplina @wmudge