Skip to content

Conversation

@wmudge
Copy link
Member

@wmudge wmudge commented Nov 17, 2023

A module/action pair for building a single, composite Cloudera Manager cluster template from a set of cluster template "fragments." The plugins handle the merger of the JSON configuration files much like ansible.builtin.assemble but honor elements of the cluster template schema.

@wmudge wmudge added the enhancement MINOR - New feature or enhancement entry in the CHANGELOG label Nov 17, 2023
@wmudge wmudge added this to the Release 4.2.0 milestone Nov 17, 2023
@wmudge wmudge requested a review from a team November 17, 2023 18:09
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Nov 17, 2023
import tempfile

from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.common.text.converters import to_native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think " to_text" should be also imported as its used on line #251

Copy link
Contributor

@rsuplina rsuplina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an import for to_text in modules/assemble_cluster_template.py

Signed-off-by: Webster Mudge <[email protected]>
@github-actions github-actions bot removed the validated The pull request has passed the prechecks label Nov 20, 2023
@wmudge wmudge requested a review from rsuplina November 20, 2023 14:22
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Nov 20, 2023
@wmudge wmudge merged commit 5110fdd into cloudera-labs:devel Nov 20, 2023
@wmudge wmudge deleted the feature/assemble_cluster_template branch November 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement MINOR - New feature or enhancement entry in the CHANGELOG validated The pull request has passed the prechecks

Development

Successfully merging this pull request may close these issues.

2 participants