Subnet filters for the DF service #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. |
wmudge
requested changes
Jul 14, 2022
Member
wmudge
left a comment
wmudge
left a comment
There was a problem hiding this comment.
Need to add jmespath to the requirements.
asdaraujo
force-pushed
the
df-service-filters
branch
from
6eb4d30 to
20fee34
Compare
Contributor
Author
|
Any updates on this? |
Chaffelson
suggested changes
Nov 10, 2022
Contributor
Chaffelson
left a comment
Chaffelson
left a comment
There was a problem hiding this comment.
Looks good generally, I would prefer that the function to apply the jmes path is refactored into the common utilities package however.
And shortened a few other message lines. Signed-off-by: Andre Araujo <[email protected]>
Due to being extracted with the wrong name (lb_subnets) Signed-off-by: Andre Araujo <[email protected]>
Signed-off-by: Andre Araujo <[email protected]>
…to module. Signed-off-by: Andre Araujo <[email protected]>
Signed-off-by: Andre Araujo <[email protected]>
Signed-off-by: Andre Araujo <[email protected]>
asdaraujo
force-pushed
the
df-service-filters
branch
from
5d135e0 to
2af8d37
Compare
wmudge
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some issues that existed in the original df_service module.
Added subnet filter options to allow for more flexibility when enabling the service.