Skip to content

Remove tls alias for verify_tls #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 10, 2025
Merged

Remove tls alias for verify_tls #188

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af3dde4
Remove tls alias for verify_tls
jimright Sep 6, 2025
c638c44
Add verify_api_tls as alias for verify_tls argument
jimright Sep 8, 2025
43503ab
Fix lint issues
jimright Sep 8, 2025
13e19c2
Fix lint issues
jimright Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions plugins/module_utils/cdp_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _impl(self, *args, **kwargs):
def __init__(self, module):
# Set common parameters
self.module = module
self.tls = self._get_param("verify_tls", False)
self.verify_tls = self._get_param("verify_tls", False)
self.debug = self._get_param("debug", False)
self.strict = self._get_param("strict", False)
self.agent_header = self._get_param("agent_header", "ClouderaFoundry")
Expand All @@ -61,7 +61,7 @@ def __init__(self, module):
# Client Wrapper
self.cdpy = Cdpy(
debug=self.debug,
tls_verify=self.tls,
tls_verify=self.verify_tls,
strict_errors=self.strict,
error_handler=self._cdp_module_throw_error,
warning_handler=self._cdp_module_throw_warning,
Expand Down Expand Up @@ -103,7 +103,12 @@ def argument_spec(**spec):
"""Default Ansible Module spec values for convenience"""
return dict(
**spec,
verify_tls=dict(required=False, type="bool", default=True, aliases=["tls"]),
verify_tls=dict(
required=False,
type="bool",
default=True,
aliases=["verify_api_tls"],
),
debug=dict(
required=False,
type="bool",
Expand Down
Loading