Skip to content

Add Terraform deployment engine for cloud resources #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 25, 2022
Merged

Add Terraform deployment engine for cloud resources #65

merged 5 commits into from
Feb 25, 2022

Conversation

jimright
Copy link
Contributor

@jimright jimright commented Oct 5, 2021

Code changes and doc update for Terraform deployment of cloud resources.

Changes done in conjunction with this cloudera.exe PR: cloudera-labs/cloudera.exe#56

@jimright jimright marked this pull request as ready for review October 27, 2021 14:05
@wmudge wmudge self-requested a review November 16, 2021 20:56
@wmudge wmudge added the enhancement New feature or request label Nov 16, 2021
@jimright jimright force-pushed the feature/terraform_infra branch from 63d3b84 to 79a0816 Compare December 1, 2021 19:39
Chaffelson
Chaffelson suggested changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@Chaffelson Chaffelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation will leave the user with lost state if they reset the cloudera-runner, but otherwise it's looking good apart from some suggested enhancements.

Chaffelson
Chaffelson reviewed Dec 13, 2021
View reviewed changes
@jimright
Copy link
Contributor Author

Main changes in latest push of code:

  • terraform_base_dir variable introduced which specifies top-level directory where all Terraform assets should be placed
    • If not specified this defaults to a directory under the config path (~/.config/cloudera-deploy/terraform) so that data and state is persisted between container resets
    • Other directory variables (template_dir, workspace_dir) are no longer needed
  • A terrform_auto_remote_state variable added which automatically creates (and deletes during teardown) the Terraform remote state resources (S3 bucket and DynamoDB table).
    • The names of the remote state resources will be derived from the name_prefix if not specified
  • Some validation of the terraform related variables

Should be ready for a re-test now.

@jimright jimright requested a review from Chaffelson December 13, 2021 16:53
@wmudge wmudge merged commit 0526f52 into cloudera-labs:devel Feb 25, 2022
Chaffelson pushed a commit to Chaffelson/cloudera-deploy that referenced this pull request Mar 9, 2022
@jimright @Chaffelson
Add Terraform deployment engine for cloud resources (cloudera-labs#65)
54490d0 
* Add parameters for Terraform deployment engine
* Update README with details of Terraform deployment
* Use ansible tags to determine action on remote state resources
* Consolidate Teardown tasks in main.yml into a single play

Signed-off-by: Jim Enright <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmudge wmudge wmudge approved these changes

+1 more reviewer

@Chaffelson Chaffelson Chaffelson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimright @wmudge @Chaffelson