Skip to content

Add private cluster parameters #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Add private cluster parameters #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b51bf0
Add enable_private_network option to enable CDE service
jimright Nov 17, 2023
119a060
Add private_cluster to enable CDF service
jimright Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/cdpy/de.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ def list_services(self, env=None, remove_deleted=False):
def enable_service(self, name, env, instance_type, minimum_instances, maximum_instances,
initial_instances=None, minimum_spot_instances=None, maximum_spot_instances=None,
initial_spot_instances=None, chart_value_overrides=None, enable_public_endpoint=False,
enable_workload_analytics=False, root_volume_size=None, skip_validation=False,
tags=None, use_ssd=False, loadbalancer_allowlist=None, whitelist_ips=None):
enable_private_network=False, enable_workload_analytics=False, root_volume_size=None,
skip_validation=False, tags=None, use_ssd=False, loadbalancer_allowlist=None, whitelist_ips=None):
return self.sdk.call(
svc='de', func='enable_service', ret_field='service', squelch=[
Squelch(value='PATH_DISABLED', warning=ENTITLEMENT_DISABLED)
Expand All @@ -93,6 +93,7 @@ def enable_service(self, name, env, instance_type, minimum_instances, maximum_in
initialSpotInstances=initial_spot_instances,
chartValueOverrides=chart_value_overrides,
enablePublicEndpoint=enable_public_endpoint,
enablePrivateNetwork=enable_private_network,
enableWorkloadAnalytics=enable_workload_analytics,
rootVolumeSize=root_volume_size,
skipValidation=skip_validation,
Expand Down
10 changes: 5 additions & 5 deletions src/cdpy/df.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@ def resolve_service_crn_from_name(self, name, only_enabled=True):
self.sdk.throw_error(CdpError("Multiple DataFlow Services found matching name %s" % name))

def enable_service(self, env_crn: str, lb_ips: list = None, min_nodes: int = 3, max_nodes: int = 3,
enable_public_ip: bool = True, kube_ips: list = None, cluster_subnets: list = None,
lb_subnets: list = None, tags: dict = None):
enable_public_ip: bool = True, private_cluster: bool = False, kube_ips: list = None,
cluster_subnets: list = None, lb_subnets: list = None, tags: dict = None):
self.sdk.validate_crn(env_crn)
return self.sdk.call(
svc='df', func='enable_service', ret_field='service',
environmentCrn=env_crn, minK8sNodeCount=min_nodes, maxK8sNodeCount=max_nodes,
usePublicLoadBalancer=enable_public_ip, kubeApiAuthorizedIpRanges=kube_ips,
loadBalancerAuthorizedIpRanges=lb_ips, clusterSubnets=cluster_subnets,
loadBalancerSubnets=lb_subnets, tags=tags
usePublicLoadBalancer=enable_public_ip, privateCluster=private_cluster,
kubeApiAuthorizedIpRanges=kube_ips, loadBalancerAuthorizedIpRanges=lb_ips,
clusterSubnets=cluster_subnets, loadBalancerSubnets=lb_subnets, tags=tags
)

def disable_service(self, df_crn: str, persist: bool = False, terminate=False):
Expand Down