Skip to content

Fix empty list/dict check for common and application configs as well … #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Fix empty list/dict check for common and application configs as well … #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cdpy/dw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,11 @@ def create_vw(self, cluster_id:str, dbc_id:str, vw_type:str, name:str, template:

if any(x is not None for x in [common_configs, application_configs, ldap_groups, enable_sso]):
config = {}
if common_configs is not None and not common_configs:
if common_configs is not None and common_configs:
config['commonConfigs'] = common_configs
if application_configs is not None and not application_configs:
if application_configs is not None and application_configs:
config['applicationConfigs'] = application_configs
if ldap_groups is not None and not ldap_groups:
if ldap_groups is not None and ldap_groups:
config['ldapGroups'] = ldap_groups
if enable_sso is not None:
config['enableSSO'] = enable_sso
Expand Down