Broken error list with 'showValidatorFailures'

[rekrios]

Hi.
You can get broken error list with LaravelJsonApi::showValidatorFailures() when your Clousure/CustomRuleClass returns array as error message coz then there are different keys.

https://monosnap.com/file/VOFYTBPnVOQoC7DTrP8ZwMhDuoqwA7

1. rule and answer in different places
2. maybe try to get array's associative key when we have ordinary Closure ? Coz 'closure-validation-rule' is not very informative. For example,
   $rules = ['rulesName' => function(...) {...}]
   The only way for now, if u want to get normal info in 'rule' - use custom rule. Coz there are 'get_class($rule)' interpreter.
   $rules = [new CustomRule()]
3. coz of problem with diffrerent keys (1), some rules are missed

P.S. maybe i will fix it myself if we will come to some consensus

[lindyhopchris]

Ugh. Laravel.

Anyway, this is because the rule interface has changed... when I first wrote that functionality the method only returned a string, not an array of strings.

This won't be an easy solution... while I love the idea of this functionality, the reason it is not on by default is because of how bad Laravel makes dealing with these things.

I'll put trying to fix this on the 2.0 milestone, but not totally sure how easy this will be to fix.

[rekrios]

Best structure of data )
Maybe for closures get info from initial rule? We can see 'failed' there
https://monosnap.com/file/FJWlofS8RSdIziCw2LAJbpFt1eD7lm

P.S. this winter i already had this problem and i had code like this

public function __construct(ValidationException $exception, $prefix = '')
    {
        $errors = new ErrorCollection();

        foreach ($exception->validator->failed() as $attribute => $fails) {
            $source = !empty($prefix) ? $prefix . '/' . $attribute : $attribute;

            foreach ($fails as $rule => $reason) {                                      // for standard validators
                if ($rule != ClosureValidationRule::class) {
                    $errors[] = new Error(null, null, $exception->status, strtolower($rule), null, null, [$source], $this->getDebugInfo());
                }
            }

            foreach ($exception->validator->getRules()[$attribute] as $rule) { //for Closures
                if ($rule instanceof ClosureValidationRule) {
                    if ($rule->failed == true) {
                        $errors[] = new Error(null, null, $exception->status, $rule->message, null, null, [$source], $this->getDebugInfo());
                    }
                }
            }
        }

        parent::__construct($errors, $exception->status);
    }

[lindyhopchris]

I'll be honest, I won't really understand this until I've had a dig into the code myself. I think this needs to some tests reproducing the problem, then we can put in the code that fixes those broken tests.

I'm happy to look at PRs on this but at the moment due to other work demands I can't prioritise this right now. Are you interested in doing a PR with tests?

[rekrios]

I'm interested in PR, but didn't make tests before. Say where to place them and i will try

[lindyhopchris]

Will see if I have some time later this month to add some failing tests for this use case on a branch, and then we can take it from there.

[lindyhopchris]

Have changed to the 1.0 milestone to see if we can fix it on that... if not will have to move it back to the 2.0 milestone.

[rekrios]

Will be great for 1.* =) Anyway, problem will be the same for both versions

[lindyhopchris]

Closing this due to inactivity.

I'll be honest, I don't use this functionality - and it's still of by default - because it's error prone. I'd take a PR to fix it, but unfortunately it's not something I can spend time on when I'm not using it. Too much other stuff to do!!