-
Notifications
You must be signed in to change notification settings - Fork 30
Open
Description
It would be nice to flag additional user agents using an environment variable
terraform-aws-clickops-notifier/clickopsnotifier/clickops.py
Lines 84 to 91 in be9694c
| self.USER_AGENTS_RE = [ | |
| "signin.amazonaws.com(.*)", | |
| "^S3Console", | |
| "^\[S3Console", # noqa: W605 | |
| "^Mozilla/", | |
| "^console(.*)amazonaws.com(.*)", | |
| "^aws-internal(.*)AWSLambdaConsole(.*)", | |
| ] |
One example is the aws-cli
"[aws-cli/2.22.28 md/awscrt#0.23.4 ua/2.0 os/macos#24.2.0 md/arch#arm64 lang/python#3.12.8 md/pyimpl#CPython cfg/retry-mode#standard md/installer#source md/prompt#off md/command#s3api.put-bucket-policy]",
This useragent can be caught using ^\[aws-cli\/ regex
It would be nice to pass this in as a var to the module
additional_user_agents_re = [
"^\[aws-cli\/",
]or be allowed to override them completely
user_agents_re = [
"signin.amazonaws.com(.*)",
"^S3Console",
"^\[S3Console", # noqa: W605
"^Mozilla/",
"^console(.*)amazonaws.com(.*)",
"^aws-internal(.*)AWSLambdaConsole(.*)",
"^\[aws-cli\/",
]or both
user_agents_re = [
"signin.amazonaws.com(.*)",
"^S3Console",
"^\[S3Console", # noqa: W605
"^Mozilla/",
"^console(.*)amazonaws.com(.*)",
"^aws-internal(.*)AWSLambdaConsole(.*)",
]
additional_user_agents_re = [
"^\[aws-cli\/",
]Maybe even customizing the non regex user agents would be nice too
| self.USER_AGENTS = {"console.amazonaws.com", "Coral/Jakarta", "Coral/Netty4"} |
Metadata
Metadata
Assignees
Labels
No labels