Skip to content

Set buffer local comint-input-sender-no-newline #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arichiardi
Copy link
Contributor

Now that the sanitation code appends a final newline to the command we need to
tell comint not to add one.

Together with #137, it should
bring things back to normal and definitely more correct.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our [contribution guidelines][1]
  • The new code is not generating bytecode or M-x checkdoc warnings

Now that the sanitation code appends a final newline to the command we need to
tell comint not to add one.
@arichiardi
Copy link
Contributor Author

So for posterity, this solution does not actually work.

Because of process-send-eof called at the end of comint-simple-send, which I have no idea of what is intended to achieve, an error is throw saying that there is no process associated with the buffer we execute in, which is a source buffer (only *inf-clojure* has a process associated with it).

So either we set a process for our source files, losing the flexibility of having many *inf-clojure* per source file, or we use something else for sending commands.

A super low-level comint-send-string is used there and I am going to try that one in another PR.

@arichiardi arichiardi closed this Feb 24, 2018
@arichiardi arichiardi mentioned this pull request Feb 24, 2018
2 tasks
@arichiardi arichiardi deleted the set-input-sender-no-newline branch March 1, 2018 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant