Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #77
Some highlights:
markdown_inline
tomarkdown-inline
.markdown-ts-mode
was added to Emacs master and it expectsmarkdown-inline
grammar (https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/textmodes/markdown-ts-mode.el#n62), so I decided to makeclojure-ts-mode
aligned with Emacs master (otherwise there would be 2 markdown inline binaries)clojure-ts-reinstall-grammars
functionmarkdown-inline
feature and I couldn't reproduce memory leak. Hopefully it's fixed by updating the grammar. But I'm still observing the problem with incorrect fontification when backticks in the docstrings are unbalanced, as mentioned in Issues with markdown inline #60. I'm thinking about submitting a bug report to Emacs and get some help regarding this situation.markdown-inline
grammar, now when backticks are balanced, they are always highlighted correctly.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdoc
and fixed any warnings in the code you've written.Thanks!