Skip to content

Use temp repl buffer for client local vars tests #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Use temp repl buffer for client local vars tests #3297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 41 additions & 64 deletions test/cider-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,70 +588,47 @@
(after-each
(setq cider-cljs-repl-types -cider-cljs-repl-types))

(describe "sets nrepl client local vars correctly"
(it "for nbb project"
(let* ((server-process (nrepl-start-mock-server-process))
(server-buffer (process-buffer server-process)))
;; wait for the connection to be established
(nrepl-tests-poll-until (local-variable-p 'nrepl-endpoint server-buffer) 5)
(let ((client-buffer (cider-connect-sibling-cljs
'(:cljs-repl-type nbb) server-buffer)))

;; native cljs REPL
(expect (buffer-local-value 'cider-repl-type client-buffer)
:to-equal 'cljs)
(expect (buffer-local-value 'cider-repl-cljs-upgrade-pending client-buffer)
:to-equal nil)
(expect (buffer-local-value 'cider-repl-init-function client-buffer)
:to-be nil)
(delete-process (get-buffer-process client-buffer)))))
(it "for shadow project"
(let* ((cider-shadow-default-options "a-shadow-alias")
(server-process (nrepl-start-mock-server-process))
(server-buffer (process-buffer server-process)))
;; wait for the connection to be established
(nrepl-tests-poll-until (local-variable-p 'nrepl-endpoint server-buffer) 5)
;; starts as clj REPL and requires a form to switch over to cljs
(let ((client-buffer (cider-connect-sibling-cljs
'(:cljs-repl-type shadow) server-buffer)))
(expect (buffer-local-value 'cider-repl-type client-buffer)
:to-equal 'cljs)
(expect (buffer-local-value 'cider-repl-cljs-upgrade-pending client-buffer)
:to-equal t)
(expect (buffer-local-value 'cider-repl-init-function client-buffer)
:not :to-be nil)
(delete-process (get-buffer-process client-buffer)))))
(it "for a custom cljs REPL type project"
(cider-register-cljs-repl-type 'native-cljs)
(let* ((server-process (nrepl-start-mock-server-process))
(server-buffer (process-buffer server-process)))
;; wait for the connection to be established
(nrepl-tests-poll-until (local-variable-p 'nrepl-endpoint server-buffer) 5)
(let ((client-buffer (cider-connect-sibling-cljs
'(:cljs-repl-type native-cljs)
server-buffer)))
(expect (buffer-local-value 'cider-repl-type client-buffer)
:to-equal 'cljs)
(expect (buffer-local-value 'cider-repl-cljs-upgrade-pending client-buffer)
:to-equal nil)
(delete-process (get-buffer-process client-buffer)))))
(it "for a custom REPL type project that needs to switch to cljs"
(cider-register-cljs-repl-type
'not-cljs-initially "(form-to-switch-to-cljs-repl)")
(let* ((server-process (nrepl-start-mock-server-process))
(server-buffer (process-buffer server-process)))
;; wait for the connection to be established
(nrepl-tests-poll-until (local-variable-p 'nrepl-endpoint server-buffer) 5)
(let ((client-buffer (cider-connect-sibling-cljs
'(:cljs-repl-type not-cljs-initially)
server-buffer)))
(expect (buffer-local-value 'cider-repl-type client-buffer)
:to-equal 'cljs)
(expect (buffer-local-value 'cider-repl-cljs-upgrade-pending client-buffer)
:to-equal t)
(expect (buffer-local-value 'cider-repl-init-function client-buffer)
:not :to-be nil)
(delete-process (get-buffer-process client-buffer)))))))
(describe "sets nrepl client buffer local vars correctly"
;; we only care to test in the below that some well specified local vars are
;; set in the nREPL client buffer at start up. To do so, we bring up the
;; mock server and call `cider-connect-sibling-cljs` to establish the
;; connection.
(it "for a custom cljs REPL type project"
(with-temp-buffer
(cider-register-cljs-repl-type 'native-cljs)
(let* ((server-process (nrepl-start-mock-server-process))
(server-buffer (process-buffer server-process)))
;; wait for the connection to be established
(nrepl-tests-poll-until (local-variable-p 'nrepl-endpoint server-buffer) 5)
(let ((client-buffer (cider-connect-sibling-cljs
`(:cljs-repl-type native-cljs :repl-buffer ,(current-buffer))
server-buffer)))
(expect (buffer-local-value 'cider-repl-type client-buffer)
:to-equal 'cljs)
(expect (buffer-local-value 'cider-repl-cljs-upgrade-pending client-buffer)
:to-equal nil)
;; kill server
(delete-process (get-buffer-process client-buffer))))))
(it "for a custom REPL type project that needs to switch to cljs"
(with-temp-buffer
(cider-register-cljs-repl-type
'not-cljs-initially "(form-to-switch-to-cljs-repl)")
(let* ((server-process (nrepl-start-mock-server-process))
(server-buffer (process-buffer server-process)))
;; wait for the connection to be established
(nrepl-tests-poll-until (local-variable-p 'nrepl-endpoint server-buffer) 5)
(let ((client-buffer (cider-connect-sibling-cljs
`(:cljs-repl-type not-cljs-initially
:repl-buffer ,(current-buffer))
server-buffer)))
(expect (buffer-local-value 'cider-repl-type client-buffer)
:to-equal 'cljs)
(expect (buffer-local-value 'cider-repl-cljs-upgrade-pending client-buffer)
:to-equal t)
(expect (buffer-local-value 'cider-repl-init-function client-buffer)
:not :to-be nil)
;; kill server
(delete-process (get-buffer-process client-buffer))))))))

(provide 'cider-tests)

Expand Down