Various fixes #128
Merged
Various fixes #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a key by default
…th arguments from input.
Contributor
|
@VincentChalnot pour ce qui est de symfony 6, c'est sur la branche v4-dev car il y a pas mal de changements à faire (sur les loggers notamment) donc le composer.json ne suffit pas. Et puis on en profite pour refacto le module. Pour le reste tu peux laisser sur une seule PR oui. |
Contributor
Author
|
Ah oui effectivement, je vois que tous les tests sont pétés. J'avais pas constaté de problème parce que je n'utilisais que les transformer dans mon projet actuel. Ok je drop la partie compatibilité Sf6. |
Contributor
Author
|
Done, je te laisse merger ça dans v4-dev ou tu veux que je refasse une PR après ton merge ? |
Contributor
|
@VincentChalnot non je vais merger ça tranquillement. |
Contributor
Author
|
Merci ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new Instantiate Transformer.
Allowing WrapperTransformer to work without specifying a key (0 by default).
composer.json update for Symfony 6.
Breaking changes
No breaking changes
Hello @xaviermarchegay, dis moi si tu veux que je split cette pull request en 3.