Skip to content

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Nov 14, 2025

Description

Small PR replacing @clerk/types with @clerk/shared/types

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Optimized internal dependency management for the Expo Passkeys module to improve code organization and maintainability.

@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Nov 14, 2025 5:10pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: 4c399dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

Walkthrough

This pull request reorganizes type dependencies in the expo-passkeys package by removing the unused @clerk/types dependency and migrating imports to @clerk/shared/types. The change is purely organizational with no functional modifications.

Changes

Cohort / File(s) Summary
Dependency cleanup
packages/expo-passkeys/package.json
Removed unused @clerk/types dependency from the dependencies section.
Import migration
packages/expo-passkeys/src/ClerkExpoPasskeys.types.ts
Updated import paths for Clerk public key credential response types from @clerk/types to @clerk/shared/types.
Release documentation
.changeset/chilled-doors-breathe.md
Added changeset file documenting patch release with note on shared types import migration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that @clerk/shared/types exports the same type definitions previously imported from @clerk/types
  • Confirm @clerk/types dependency is not referenced elsewhere in the package

Poem

🐰 Types took a hop, from one home to the next,
Through @clerk/shared they dance, less perplexed,
Dependencies pruned, imports rearranged,
The functionality stayed—just the address changed! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly describes the main change: migrating type imports in the expo-passkeys package from @clerk/types to @clerk/shared/types, which aligns with the changeset content.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/expo-passkeys-shared-types

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7220

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7220

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7220

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7220

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7220

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7220

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7220

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7220

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7220

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7220

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7220

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7220

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7220

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7220

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7220

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7220

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7220

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7220

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7220

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7220

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7220

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7220

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7220

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7220

commit: 4c399dc

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/chilled-doors-breathe.md (1)

5-5: Consider a slightly more descriptive changelog entry.

The description "Migrate shared types imports" is accurate but minimal. For better clarity in the changelog, consider adding a brief note about what types were migrated or why. For example: "Migrate shared types imports from @clerk/types to @clerk/shared/types" would help users understand the scope of the change.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ee0671f and 4c399dc.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • .changeset/chilled-doors-breathe.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/chilled-doors-breathe.md (1)

1-5: Changeset format and content look good.

The changeset is correctly formatted with the appropriate patch version bump for a non-breaking reorganization of type dependencies. The description aligns with the PR objectives.

@wobsoriano wobsoriano changed the title chore(expo-passkeys): Migrate shared types imports chore(expo-passkeys): Migrate types import Nov 14, 2025
@wobsoriano wobsoriano merged commit d537fd2 into main Nov 14, 2025
46 of 47 checks passed
@wobsoriano wobsoriano deleted the rob/expo-passkeys-shared-types branch November 14, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants