chore(tanstack-react-start): Constrain TanStack dependencies to pre-RC versions #6845
Conversation
🦋 Changeset detectedLatest commit: 08d750f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR adds a changeset for a minor release and updates package.json in packages/tanstack-react-start to pin devDependency versions and constrain peerDependency ranges for @tanstack/react-router and @tanstack/react-start below 1.132.0. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.changeset/fast-dolls-float.md (1)
5-5: Tighten wording to list affected packages explicitly.Spell out “@tanstack/react-router and @tanstack/react-start” to remove ambiguity from “@tanstack/*”.
-Constrained TanStack dependencies to pre-RC versions. Please ensure you're using `@tanstack/*` versions below `1.132.0`. +Constrained TanStack dependencies to pre-RC versions. Please ensure you're using `@tanstack/react-router` and `@tanstack/react-start` versions below `1.132.0`.packages/tanstack-react-start/package.json (2)
79-81: Good dev pinning to pre‑RC; consider adding pnpm overrides to prevent accidental hoisting.In monorepos, a higher RC elsewhere can hoist and leak via dedupe.
pnpm.overridesat the package level guarantees 1.131.34 resolution for local dev.Add overrides:
{ "name": "@clerk/tanstack-react-start", ... "devDependencies": { "@tanstack/react-router": "1.131.34", "@tanstack/react-start": "1.131.34", "esbuild-plugin-file-path-extensions": "^2.1.4" }, + "pnpm": { + "overrides": { + "@tanstack/react-router": "1.131.34", + "@tanstack/react-start": "1.131.34" + } + }, "peerDependencies": { ... } }
84-86: Use explicit bounded ranges;<1.132.0already excludes prereleasesReplace
^1.131.0 <1.132.0with>=1.131.0 <1.132.0for clarity across npm/Yarn/pnpm — both forms are equivalent, and node-semver will NOT match prereleases like1.132.0-rc.*unless the range mentions a prerelease or includePrerelease is used.- "@tanstack/react-router": "^1.131.0 <1.132.0", - "@tanstack/react-start": "^1.131.0 <1.132.0", + "@tanstack/react-router": ">=1.131.0 <1.132.0", + "@tanstack/react-start": ">=1.131.0 <1.132.0",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
.changeset/fast-dolls-float.md(1 hunks)packages/tanstack-react-start/package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/fast-dolls-float.md
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/tanstack-react-start/package.json
packages/*/package.json
📄 CodeRabbit inference engine (.cursor/rules/global.mdc)
All publishable packages should be placed under the packages/ directory
packages/*/package.json: All publishable packages must be located in the 'packages/' directory.
All packages must be published under the @clerk namespace on npm.
Semantic versioning must be used across all packages.
Files:
packages/tanstack-react-start/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (machine, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (custom, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (tanstack-react-router, chrome)
- GitHub Check: Integration Tests (quickstart, chrome)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Unit Tests (22, **)
- GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
- GitHub Check: Static analysis
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/fast-dolls-float.md (1)
1-3: Changeset looks correct; confirm release type aligns with policy.Minor bump makes sense, but narrowing peer ranges can be construed as breaking for users already on 1.132.0 RC. Confirm this matches your semver/release policy for the SDK.
Would you like to bump this to major to reflect the stricter peer range, or keep minor since RC users are already broken?
|
@wobsoriano this should be safe to merge then, right ? |
Yes! |
Description
TanStack Router v1.132.0 RC introduced features that include breaking changes to our custom server handler, which breaks our Clerk TanStack Start SDK integration. This PR will maintain compatibility while waiting for the next version which will have the updated API and be the last API before TanStack Start and our SDK goes to stable 🥳
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit