Skip to content

chore(vue,nuxt): Set default GoogleOneTap prop values #6809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 19, 2025
Merged

chore(vue,nuxt): Set default GoogleOneTap prop values #6809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e133a10
chore(nuxt): Add GoogleOneTap to auto-imported components
wobsoriano Sep 18, 2025
cb6fab9
chore: add changeset
wobsoriano Sep 18, 2025
6253885
chore(vue): Set GoogleOneTap props default values
wobsoriano Sep 19, 2025
b9f4c14
chore: update changeset
wobsoriano Sep 19, 2025
fddd52c
chore: update changeset
wobsoriano Sep 19, 2025
6a08ac8
chore: update changeset
wobsoriano Sep 19, 2025
1714ad0
chore: add vue changeset
wobsoriano Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clean-cars-fly.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/vue": patch
---

Fixed incorrect default prop values passed to `<GoogleOneTap />` component
5 changes: 5 additions & 0 deletions .changeset/twelve-carrots-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/nuxt": patch
---

Added `<GoogleOneTap />` to auto-imported components.
4 changes: 3 additions & 1 deletion packages/nuxt/src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ export default defineNuxtModule<ModuleOptions>({
// Authentication Components
'SignIn',
'SignUp',
'GoogleOneTap',
// Unstyled Components
'SignInButton',
'SignOutButton',
Expand All @@ -154,6 +155,8 @@ export default defineNuxtModule<ModuleOptions>({
'OrganizationProfile',
'OrganizationSwitcher',
'OrganizationList',
// Billing Components
'PricingTable',
Comment on lines +158 to +159
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

🧩 Analysis chain

Verify PricingTable component organization and duplication removal.

The reorganization places PricingTable under "Billing Components" which is semantically correct. However, I need to verify that the duplicate PricingTable entry was actually removed and that this component exists in @clerk/vue.

🏁 Script executed:

#!/bin/bash
# Description: Verify PricingTable organization and check for duplicates in the module

# Check if PricingTable appears only once in the components array
echo "Checking PricingTable occurrences in module.ts:"
rg -n "PricingTable" packages/nuxt/src/module.ts

# Verify PricingTable export exists in @clerk/vue
echo -e "\nChecking if PricingTable is exported from @clerk/vue:"
rg -n "PricingTable" packages/vue/src/index.ts || echo "Not found in vue/src/index.ts, checking other export files..."

# Check for PricingTable component definition
echo -e "\nSearching for PricingTable component definition:"
fd -t f -e ts -e tsx | xargs rg -l "PricingTable" | head -10

Length of output: 769

Export PricingTable from @clerk/vue or update Nuxt module import

  • packages/nuxt/src/module.ts contains a single 'PricingTable' entry (packages/nuxt/src/module.ts:159) — duplicate removed.
  • Component implementation exists at packages/clerk-js/src/ui/components/PricingTable/(index.tsx, PricingTable.tsx) but is not exported from packages/vue/src/index.ts.
  • Action: either re-export PricingTable from packages/vue/src/index.ts (pointing to the clerk-js implementation) or update packages/nuxt/src/module.ts to register/import the component from the package that actually exposes it.
🤖 Prompt for AI Agents 
In packages/nuxt/src/module.ts around lines 158-159, Nuxt registers a
'PricingTable' component but that component isn't exported from
packages/vue/src/index.ts (the actual implementation lives at
packages/clerk-js/src/ui/components/PricingTable). Fix by either: (A)
re-exporting the component from packages/vue/src/index.ts by adding an export
that points to ../../clerk-js/src/ui/components/PricingTable (so @clerk/vue
exposes PricingTable for the Nuxt module), or (B) change
packages/nuxt/src/module.ts to import/register the component directly from
packages/clerk-js/src/ui/components/PricingTable instead of @clerk/vue; ensure
imports use the correct relative package path and update any index exports to
avoid duplicate entries.

// Control Components
'ClerkLoaded',
'ClerkLoading',
Expand All @@ -166,7 +169,6 @@ export default defineNuxtModule<ModuleOptions>({
'SignedIn',
'SignedOut',
'Waitlist',
'PricingTable',
];
components.forEach(component => {
void addComponent({
Expand Down
6 changes: 5 additions & 1 deletion packages/vue/src/components/ui-components/GoogleOneTap.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ import type { GoogleOneTapProps } from '@clerk/types';

const clerk = useClerk();

const props = defineProps<GoogleOneTapProps>();
const props = withDefaults(defineProps<GoogleOneTapProps>(), {
cancelOnTapOutside: true,
itpSupport: true,
fedCmSupport: true,
});
</script>

<template>
Expand Down
Loading