-
Notifications
You must be signed in to change notification settings - Fork 389
chore(repo): Hide @experimental from typedoc rendering #6651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
845b750
347a488
4d6561b
0d3c98c
a627eb8
b037879
02d730d
c4b7cf0
d8c5dc2
6b7da9f
def7a20
0c3d485
dea5e8e
4171b93
a07e9b0
6ff75ef
dc69c34
a87f384
a65289d
a82e880
6dc4f19
3c104a0
5abfef4
76769f0
b36edf5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
'@clerk/clerk-js': patch | ||
'@clerk/backend': patch | ||
'@clerk/shared': patch | ||
'@clerk/clerk-react': patch | ||
'@clerk/types': patch | ||
'@clerk/clerk-expo': patch | ||
--- | ||
|
||
Update jsdocs mentions of `@experimental` tag. |
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -218,13 +218,19 @@ class ClerkMarkdownThemeContext extends MarkdownThemeContext { | |||||||||||||||||||||||||||||||||||
const customizedModel = model; | ||||||||||||||||||||||||||||||||||||
customizedModel.typeParameters = undefined; | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
// Extract the Accessors group (if any) and prevent default rendering for it | ||||||||||||||||||||||||||||||||||||
const originalGroups = customizedModel.groups; | ||||||||||||||||||||||||||||||||||||
const accessorsGroup = originalGroups?.find(g => g.title === 'Accessors'); | ||||||||||||||||||||||||||||||||||||
const groupsWithoutAccessors = originalGroups?.filter(g => g.title !== 'Accessors'); | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
// When an interface extends another interface, typedoc will generate a "Methods" group | ||||||||||||||||||||||||||||||||||||
// We want to hide this group from being rendered | ||||||||||||||||||||||||||||||||||||
const groupsWithoutMethods = originalGroups?.filter(g => g.title !== 'Methods'); | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
// Extract the Accessors group (if any) and prevent default rendering for it | ||||||||||||||||||||||||||||||||||||
const accessorsGroup = groupsWithoutMethods?.find(g => g.title === 'Accessors'); | ||||||||||||||||||||||||||||||||||||
const groupsWithoutAccessors = groupsWithoutMethods?.filter(g => g.title !== 'Accessors'); | ||||||||||||||||||||||||||||||||||||
Comment on lines
+223
to
+229
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainHiding every “Methods” group is too broad; restrict to interfaces (extends case). As written, you’ll also remove legitimate methods from classes. Limit the filter to interface pages only. - const groupsWithoutMethods = originalGroups?.filter(g => g.title !== 'Methods');
+ const isInterface = customizedModel?.kind === ReflectionKind.Interface;
+ const groupsWithoutMethods = isInterface
+ ? originalGroups?.filter(g => g.title !== 'Methods')
+ : originalGroups; Build a sample class with methods in the docs to confirm the Methods section remains visible. 🏁 Script executed: #!/bin/bash
# Locate ReflectionKind usage and import in custom-theme.mjs
grep -R "ReflectionKind" -n .typedoc/custom-theme.mjs || true
# Locate where customizedModel is defined or passed in
grep -R "customizedModel" -n .typedoc/custom-theme.mjs || true Length of output: 1133 Restrict “Methods” filtering to interfaces only - const groupsWithoutMethods = originalGroups?.filter(g => g.title !== 'Methods');
+ const isInterface = customizedModel.kind === ReflectionKind.Interface;
+ const groupsWithoutMethods = isInterface
+ ? originalGroups.filter(g => g.title !== 'Methods')
+ : originalGroups; [matches .typedoc/custom-theme.mjs:243] 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
customizedModel.groups = groupsWithoutAccessors; | ||||||||||||||||||||||||||||||||||||
const nonAccessorOutput = superPartials.memberWithGroups(customizedModel, options); | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
customizedModel.groups = originalGroups; | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
/** @type {string[]} */ | ||||||||||||||||||||||||||||||||||||
|
Uh oh!
There was an error while loading. Please reload this page.