-
Notifications
You must be signed in to change notification settings - Fork 388
chore(repo): Skip coderabbit review for release PRs #6630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdded an ignore_title_keywords entry under reviews.auto_review in .coderabbit.yaml to exclude the title keyword "ci(repo): Version packages" from auto-review title checks. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.coderabbit.yaml (3)
3-4
: Broaden skipping logic to cover common release-PR title variants.Relying on a single literal keyword may miss bot-generated titles that vary slightly across time or tooling (e.g., different casing or scope such as “ci(changesets): version packages”). Since matching is substring + case-insensitive, consider adding a few safe variants and/or an author/label guard for better recall.
Apply this diff to add common variants:
reviews: auto_review: ignore_title_keywords: - 'ci(repo): Version packages' + - 'ci(repo): version packages' + - 'ci(changesets): version packages' + - 'version packages'Notes:
- Adding the generic 'version packages' is convenient but broader. If you worry about false positives, omit that line and rely on the two explicit variants instead.
--- `1-4`: **Add secondary guards: ignore known bot authors and/or a negative label filter.** If your release PRs are authored by a bot, using ignore_usernames is robust against future title changes. A negative label filter also works if you consistently label release PRs (e.g., “release”). Proposed diff: ```diff reviews: auto_review: ignore_title_keywords: - 'ci(repo): Version packages' + ignore_usernames: + # Replace with the actual bot usernames used in this repo + - 'changeset-release-bot' + - 'github-actions[bot]' + labels: + # Review all PRs except those carrying the release label + - '!release'
Caveats:
- The labels array is inclusive by default; including only a negative label like '!release' keeps reviews on for all PRs except those labeled 'release'. Ensure your workflow reliably applies that label to release PRs.
--- `1-4`: **Release PR title and author verification complete** - **Location:** `.coderabbit.yaml` (lines 1–4) - All recent release PRs in `clerk/javascript` (the last 50+) use the exact title `ci(repo): Version packages` and are authored by `clerk-cookie`. - There is no single stable label applied to these PRs, so the title pattern is the most reliable signal. Optional enhancement (recommended): lock the author guard to `clerk-cookie` to further reduce false positives: ```diff reviews: auto_review: ignore_title_keywords: - 'ci(repo): Version packages' + require_author: + - 'clerk-cookie'
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.coderabbit.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (machine, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (tanstack-react-router, chrome)
- GitHub Check: Integration Tests (quickstart, chrome)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Unit Tests (22, **)
- GitHub Check: Static analysis
- GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: semgrep/ci
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.coderabbit.yaml (1)
1-4
: LGTM: Schema-compliant YAML and correct placement under reviews.auto_review.The structure matches the documented schema for reviews.auto_review.ignore_title_keywords and should successfully skip auto-reviews when titles contain the given keyword (case-insensitive).
Description
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change
Summary by CodeRabbit