-
Notifications
You must be signed in to change notification settings - Fork 408
chore(clerk-js): Remove unused __internal_hasAfterAuthFlows
#6609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7fdad39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3f761b4 to
e2c29cc
Compare
e2c29cc to
04040d9
Compare
04040d9 to
7fdad39
Compare
📝 WalkthroughWalkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/common-clowns-speak.md (1)
7-7: Tighten the changeset message for clarity and release notes quality.Spell out that this was an internal, unused flag and that there are no runtime behavior changes. Including the PR number helps traceability.
Apply this diff to improve the body:
-Remove unused `__internal_hasAfterAuthFlows` property +Remove unused internal flag `__internal_hasAfterAuthFlows`. + +Notes: +- Internal only; not part of the public nomenclature or documented API. +- No runtime behavior changes. Types updated accordingly. +- See PR #6609 for context.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
.changeset/common-clowns-speak.md(1 hunks)packages/clerk-js/src/core/clerk.ts(0 hunks)packages/react/src/isomorphicClerk.ts(0 hunks)packages/types/src/clerk.ts(0 hunks)
💤 Files with no reviewable changes (3)
- packages/types/src/clerk.ts
- packages/clerk-js/src/core/clerk.ts
- packages/react/src/isomorphicClerk.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/common-clowns-speak.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (machine, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (quickstart, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Integration Tests (tanstack-react-router, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
- GitHub Check: Unit Tests (22, **)
- GitHub Check: Static analysis
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
.changeset/common-clowns-speak.md (2)
1-5: Changeset frontmatter targets all affected packages — LGTM.Patch bumps for @clerk/clerk-js, @clerk/clerk-react, and @clerk/types align with the PR intent of removing an unused internal flag. No issues with the YAML-style frontmatter.
1-5: “patch” classification is safe – no remaining code references to__internal_hasAfterAuthFlowsWe ran a repo-wide search (excluding
node_modules) and only found mentions inCHANGELOG.mdfiles. There are no usages in source code, docs, examples, or tests, so removing this internal-only flag won’t break any consumer code. Keeping the version bump as a patch is appropriate.
__internal_hasAfterAuthFlows __internal_hasAfterAuthFlows
Description
This flag has been added in the past, but it's not being used; also, after-auth is not a public nomenclature anymore as we're using session tasks as the feature name.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit