Skip to content

Conversation

@LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Aug 22, 2025

Description

This flag has been added in the past, but it's not being used; also, after-auth is not a public nomenclature anymore as we're using session tasks as the feature name.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Removed an unused internal flag related to after-auth flows and streamlined related types. No runtime behavior changes or impact to public APIs.
  • Chores
    • Released patch updates to Clerk packages to include internal cleanup.

@LauraBeatris LauraBeatris self-assigned this Aug 22, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025

🦋 Changeset detected

Latest commit: 7fdad39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Patch
@clerk/clerk-react Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/elements Patch
@clerk/nextjs Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/tanstack-react-start Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nuxt Patch
@clerk/shared Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Aug 22, 2025 4:44pm

@LauraBeatris LauraBeatris force-pushed the laura/remove-unused-after-auth-property branch from 3f761b4 to e2c29cc Compare August 22, 2025 16:41
@LauraBeatris LauraBeatris marked this pull request as ready for review August 22, 2025 16:41
@LauraBeatris LauraBeatris requested a review from a team August 22, 2025 16:41
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 22, 2025

📝 Walkthrough

Walkthrough

  • Adds a changeset bumping @clerk/clerk-js, @clerk/clerk-react, and @clerk/types with a note to remove an unused internal property.
  • Removes the getter __internal_hasAfterAuthFlows from the Clerk class in clerk-js.
  • Updates the Clerk interface in @clerk/types by removing the __internal_hasAfterAuthFlows: boolean property.
  • Adjusts the IsomorphicLoadedClerk type in react to stop omitting __internal_hasAfterAuthFlows, reflecting its removal; no runtime logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 22, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6609

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6609

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6609

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6609

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6609

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6609

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6609

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6609

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6609

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6609

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6609

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6609

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6609

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6609

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6609

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6609

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6609

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6609

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6609

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6609

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6609

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6609

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6609

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6609

commit: 7fdad39

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/common-clowns-speak.md (1)

7-7: Tighten the changeset message for clarity and release notes quality.

Spell out that this was an internal, unused flag and that there are no runtime behavior changes. Including the PR number helps traceability.

Apply this diff to improve the body:

-Remove unused `__internal_hasAfterAuthFlows` property
+Remove unused internal flag `__internal_hasAfterAuthFlows`.
+
+Notes:
+- Internal only; not part of the public nomenclature or documented API.
+- No runtime behavior changes. Types updated accordingly.
+- See PR #6609 for context.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4e15e06 and 7fdad39.

📒 Files selected for processing (4)
  • .changeset/common-clowns-speak.md (1 hunks)
  • packages/clerk-js/src/core/clerk.ts (0 hunks)
  • packages/react/src/isomorphicClerk.ts (0 hunks)
  • packages/types/src/clerk.ts (0 hunks)
💤 Files with no reviewable changes (3)
  • packages/types/src/clerk.ts
  • packages/clerk-js/src/core/clerk.ts
  • packages/react/src/isomorphicClerk.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/common-clowns-speak.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Static analysis
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
.changeset/common-clowns-speak.md (2)

1-5: Changeset frontmatter targets all affected packages — LGTM.

Patch bumps for @clerk/clerk-js, @clerk/clerk-react, and @clerk/types align with the PR intent of removing an unused internal flag. No issues with the YAML-style frontmatter.


1-5: “patch” classification is safe – no remaining code references to __internal_hasAfterAuthFlows

We ran a repo-wide search (excluding node_modules) and only found mentions in CHANGELOG.md files. There are no usages in source code, docs, examples, or tests, so removing this internal-only flag won’t break any consumer code. Keeping the version bump as a patch is appropriate.

@LauraBeatris LauraBeatris changed the title chore(clerk-js): Remove unused __internal_hasAfterAuthFlows chore(clerk-js): Remove unused __internal_hasAfterAuthFlows Aug 22, 2025
@LauraBeatris LauraBeatris enabled auto-merge (squash) August 22, 2025 16:53
@LauraBeatris LauraBeatris merged commit d52714e into main Aug 22, 2025
40 of 41 checks passed
@LauraBeatris LauraBeatris deleted the laura/remove-unused-after-auth-property branch August 22, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants