chore(clerk-js): Clear API keys revoke confirmation field on modal close #6604

wobsoriano · 2025-08-21T18:39:13Z

Description

Small PR that clears the revoke confirmation field when modal is closed

Screen.Recording.2025-08-21.at.11.38.07.AM.mov

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

New Features
- None
Bug Fixes
- The API key revoke confirmation field now clears automatically when the modal is closed, preventing stale input from persisting on reopen.
Chores
- Added a changeset to release a patch version documenting the confirmation field reset behavior.

changeset-bot · 2025-08-21T18:39:18Z

🦋 Changeset detected

Latest commit: 59f72a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-08-21T18:39:20Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
clerk-js-sandbox	Ready	Preview	Comment	Aug 21, 2025 6:56pm

coderabbitai · 2025-08-21T18:42:01Z

📝 Walkthrough

Walkthrough

A changeset file was added to declare a patch release for the package "@clerk/clerk-js" with the note: "Clear API keys revoke confirmation field on modal close."
In RevokeAPIKeyConfirmationModal.tsx, a local handleClose function now calls onClose() and clears the revoke input by setting it to an empty string.
Modal’s handleClose and FormButtons’ onReset are wired to this new handleClose.
After successful submit/mutation, the flow now invokes handleClose instead of directly calling onClose.
No exported/public APIs were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-08-21T18:43:00Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6604

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6604

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6604

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6604

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6604

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6604

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6604

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6604

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6604

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6604

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6604

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6604

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6604

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6604

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6604

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6604

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6604

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6604

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6604

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6604

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6604

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6604

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6604

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6604

commit: 59f72a6

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (5)

packages/clerk-js/src/ui/components/ApiKeys/RevokeAPIKeyConfirmationModal.tsx (5)
45-48: Clear field before calling onClose to avoid setState-on-unmounted edge case.

If onClose immediately unmounts this component, calling setValue after onClose risks a no-op or a React warning. Flip the order to make the reset deterministic.
-  const handleClose = () => {
-    onClose();
-    revokeField.setValue('');
-  };
+  const handleClose = () => {
+    revokeField.setValue('');
+    onClose();
+  };
50-59: Add error handling around revoke + optionally await cache mutation.

Per UI guidelines, API errors should be handled and localized. Also consider awaiting mutate for stronger consistency guarantees before closing (optional).

Example shape (adjust imports to your project utilities and localization):
-  await clerk.apiKeys.revoke({ apiKeyID: apiKeyId });
-  const cacheKey = { key: 'api-keys', subject };
-  void mutate(cacheKey);
-  handleClose();
+  try {
+    await clerk.apiKeys.revoke({ apiKeyID: apiKeyId });
+    const cacheKey = { key: 'api-keys', subject };
+    await mutate(cacheKey);
+    handleClose();
+  } catch (err) {
+    // TODO: use handleError/translateError to surface localized feedback
+  }
If you want, I can wire this to your existing handleError/translateError helpers in a follow-up.

36-41: Localize the label/placeholder strings.

Hard-coded user-facing strings violate the localization guideline. You already use localizationKeys('apiKeys.revokeConfirmation.confirmationText') for comparison; reuse that for the placeholder and introduce a localization key for the label.

Suggested direction:

placeholder: use localizationKeys('apiKeys.revokeConfirmation.confirmationText')

label: add a new key (e.g., apiKeys.revokeConfirmation.inputLabel) and reference it here

No diff provided since new i18n keys may be required.

23-35: Optional: memoize handlers to minimize re-renders.

Not critical here, but useCallback for handleClose/handleSubmit can help avoid unnecessary child re-renders if these props are passed down further.

100-119: Please add tests covering the new reset-on-close behavior.

No tests were added in this PR. Add at least one UI test to assert the input clears when:

The user clicks Cancel/Reset.

The revoke action succeeds and the modal closes.

The modal is closed programmatically via onClose.

I can provide a Playwright/Jest+RTL test scaffold if helpful.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ce49740 and 12066a4.

📒 Files selected for processing (2)

.changeset/cold-glasses-watch.md (1 hunks)
packages/clerk-js/src/ui/components/ApiKeys/RevokeAPIKeyConfirmationModal.tsx (4 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

.changeset/cold-glasses-watch.md

packages/clerk-js/src/ui/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/clerk-js-ui.mdc)

packages/clerk-js/src/ui/**/*.{ts,tsx}: Element descriptors should always be camelCase
Use element descriptors in UI components to enable consistent theming and styling via appearance.elements
Element descriptors should generate unique, stable CSS classes for theming
Element descriptors should handle state classes (e.g., cl-loading, cl-active, cl-error, cl-open) automatically based on component state
Do not render hard-coded values; all user-facing strings must be localized using provided localization methods
Use the useLocalizations hook and localizationKeys utility for all text and error messages
Use the styled system (sx prop, theme tokens, responsive values) for custom component styling
Use useCardState for card-level state, useFormState for form-level state, and useLoadingStatus for loading states
Always use handleError utility for API errors and use translateError for localized error messages
Use useFormControl for form field state, implement proper validation, and handle loading and error states in forms
Use localization keys for all form labels and placeholders
Use element descriptors for consistent styling and follow the theme token system
Use the Card and FormContainer patterns for consistent UI structure

Files:

packages/clerk-js/src/ui/components/ApiKeys/RevokeAPIKeyConfirmationModal.tsx

**/*.{js,jsx,ts,tsx}