Skip to content

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Jul 29, 2025

Description

Previously, the server-side cache of clerk.session would not be properly invalidated on setActive with pending session, causing if (clerk.session.currentTask) to fail.

This fix checks if setActive is not performed within internal components context, and only then invalidates the cache.

CleanShot.2025-07-29.at.11.00.14.mp4
if (signInAttempt.status === 'complete') {
    await setActive({ session: signInAttempt.createdSessionId })
 } 

 if (clerk.session?.currentTask) {
    router.push('/sign-in/tasks/select-organization')
    return;
  }

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Resolved an issue where the server-side session cache was not properly refreshed after custom authentication flows, ensuring accurate session handling.
  • New Features

    • Improved session management to prevent unnecessary UI flickers or unmounts during internal navigation after authentication.

@LauraBeatris LauraBeatris self-assigned this Jul 29, 2025
Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 2:30pm

Copy link

changeset-bot bot commented Jul 29, 2025

🦋 Changeset detected

Latest commit: 135827c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris force-pushed the laura/invalidate-cache-custom-flows branch from feaa3dd to 4799072 Compare July 29, 2025 14:08
@LauraBeatris LauraBeatris changed the title fix(clerk-js): Invalidate server cache for after-auth custom flows fix(clerk-js): Invalidate server cache for after-auth custom flows Jul 29, 2025
@LauraBeatris LauraBeatris requested a review from a team July 29, 2025 14:10
@LauraBeatris LauraBeatris marked this pull request as ready for review July 29, 2025 14:10
Copy link
Contributor

coderabbitai bot commented Jul 29, 2025

📝 Walkthrough

Walkthrough

A patch was applied to the '@clerk/clerk-js' package to address an issue with server-side session cache invalidation following custom authentication flows. The internal method #handlePendingSession in the Clerk class was updated to conditionally invoke two hooks, onBeforeSetActive and onAfterSetActive, before and after the session handling logic. These hooks are triggered only when not navigating within components, as determined by a private flag. The hooks are sourced from global window properties in browser environments and default to no-ops otherwise. Additionally, the bundlewatch configuration was updated to increase the maximum allowed bundle size for ./dist/clerk.browser.js from 72.2KB to 74KB. No public or exported entities were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95b5f42 and 135827c.

📒 Files selected for processing (1)
  • packages/clerk-js/bundlewatch.config.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/clerk-js/bundlewatch.config.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Jul 29, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6425

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6425

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6425

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6425

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6425

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6425

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6425

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6425

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6425

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6425

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6425

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6425

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6425

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6425

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6425

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6425

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6425

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6425

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6425

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6425

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6425

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6425

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6425

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6425

commit: 135827c

@LauraBeatris LauraBeatris merged commit 8fadb1d into main Jul 29, 2025
38 checks passed
@LauraBeatris LauraBeatris deleted the laura/invalidate-cache-custom-flows branch July 29, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants