fix(clerk-js, types): Add missing types in Appearance prop #5639

rion-x-coffee · 2025-04-16T03:42:13Z

Description

Add missing type of fontWeight property in variables? property of appearance prop.
https://clerk.com/docs/customization/variables#properties

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

New Features
- Introduced support for a "semibold" font weight option in appearance settings.

changeset-bot · 2025-04-16T03:42:17Z

⚠️ No Changeset found

Latest commit: ad479a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-04-16T03:42:18Z

@rion-x-coffee is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

clerk-cookie · 2025-06-06T00:01:37Z

Hello 👋

We currently close PRs after 60 days of inactivity. It's been 50 days since the last update here. If we missed this PR, please reply here. Otherwise, we'll close this PR in 10 days.

Thanks for being a part of the Clerk community! 🙏

coderabbitai · 2025-06-13T14:52:04Z

📝 Walkthrough

Walkthrough

The type definition for FontWeightScale was updated to include an optional semibold property, allowing for an additional named font weight value. No existing properties were changed or removed.

Changes

File	Change Summary
packages/types/src/appearance.ts	Added optional `semibold` property to `FontWeightScale`.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6842ff1 and ad479a3.

📒 Files selected for processing (1)

packages/types/src/appearance.ts (1 hunks)

🔇 Additional comments (1)

packages/types/src/appearance.ts (1)

60-65: Addition aligns type with documentation – looks good.

Adding the optional semibold key closes the gap between the FontWeightScale type and the docs/examples that already reference it. No breaking-change risk because all keys remain optional, and existing consumers remain unaffected.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-06-13T15:04:02Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@5639

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@5639

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@5639

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@5639

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@5639

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@5639

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@5639

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@5639

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@5639

@clerk/express

npm i https://pkg.pr.new/@clerk/express@5639

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@5639

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@5639

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@5639

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@5639

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@5639

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@5639

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@5639

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@5639

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@5639

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@5639

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@5639

@clerk/types

npm i https://pkg.pr.new/@clerk/types@5639

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@5639

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@5639

commit: ad479a3

fix(clerk-js, types): Add missing types in Appearance prop

4435601

clerk-cookie added the types label Apr 16, 2025

clerk-cookie added Stale and removed Stale labels Jun 6, 2025

Merge branch 'main' into main

ad479a3

jacekradko requested review from aeliox, wobsoriano, chanioxaris and a team as code owners June 13, 2025 14:51

jacekradko mentioned this pull request Jun 13, 2025

fix(types): Add missing semibold type #6114

Merged

9 tasks

jacekradko closed this in #6114 Jun 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(clerk-js, types): Add missing types in Appearance prop #5639

fix(clerk-js, types): Add missing types in Appearance prop #5639

rion-x-coffee commented Apr 16, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Apr 16, 2025 •

edited

Loading

Uh oh!

vercel bot commented Apr 16, 2025

Uh oh!

clerk-cookie commented Jun 6, 2025

Uh oh!

coderabbitai bot commented Jun 13, 2025 •

edited

Loading

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jun 13, 2025

Uh oh!

Uh oh!

fix(clerk-js, types): Add missing types in Appearance prop #5639

fix(clerk-js, types): Add missing types in Appearance prop #5639

Conversation

rion-x-coffee commented Apr 16, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Apr 16, 2025

Uh oh!

clerk-cookie commented Jun 6, 2025

Uh oh!

coderabbitai bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jun 13, 2025

Uh oh!

Uh oh!

rion-x-coffee commented Apr 16, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Apr 16, 2025 •

edited

Loading

coderabbitai bot commented Jun 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)