-
Notifications
You must be signed in to change notification settings - Fork 870
Ensure all hooks are using typedocs + have code examples for each supported SDK #2649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7d0c880 to
8225f3c
Compare
Yeah I was divided on this, but I agree, think it's much better to have those first and then the examples. Thanks for moving them! |
|
i think this is pretty much good to go - just waiting on a reply for clerk/javascript#6901 (comment) |
Thanks @alexisintech - I've replied. I'm getting @wobsoriano to look at the JS PR to make sure it's all good as well and it doesn't impact anything we may have not thought of, just to let you know. |
|
|
||
| When using reverification, a user's credentials are valid for 10 minutes. Once stale, a user will need to reverify their credentials. This time duration can be customized by using the `has()` helper on the server-side. See the [guide on reverification](/docs/guides/secure/reverification) for more information. | ||
|
|
||
| <Typedoc src="clerk-react/use-reverification-params" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done here: ad4cef7
|
I did a final sweep, everythings looking good but I'll let @SarahSoutoul decide and merge as she is the OP 🙏 |

🔎 Previews:
What does this solve?
Fixes https://linear.app/clerk/issue/DOCS-10983/ensure-all-hooks-are-using-typedocs-have-code-examples-for-each.
This PR is part of a broader project aimed at adding more code examples to our hooks documentation. During project discussions, we agreed that the current structure of our hooks docs needed to be revisited. Currently, most of the hook pages are fully rendered through Typedoc, including code examples. However, adding additional examples through Typedoc would have required significant restructuring of the JavaScript repo.
To address this, we decided to:
javascriptfor this: hhttps://github.com/docs(repo): Generate all params and return types (hooks work) javascript#6901.Additionally, not all hooks currently use Typedoc. This PR also ensures that all hooks are properly configured to use Typedoc for their returns and parameters.
This PR includes:
This PR will be the second in a sequence. First, we need to merge the
javascriptPR, which:What changed?
This PR adds all the code examples for the supported SDKs for each hook + uses the newly rendered Typedoc returns/ parameters, placing them after the examples for the most part.
Testing
useAuth- already using typedoc, but examples need to be moved outuseClerk- already using typedoc, but examples need to be moved outuseUser- already using typedoc, but examples need to be moved outuseSession- already using typedoc, but examples need to be moved outuseSessionList- already using typedoc, but examples need to be moved outuseSignIn- already using typedoc, but examples need to be moved outuseSignUp- - already using typedoc, but examples need to be moved outuseCheckout- need to be using typedocusePaymentAttempts- need to be using typedocusePaymentElement- need to be using typedocusePaymentMethods- need to be using typedocusePlans- need to be using typedocuseStatements- need to be using typedocuseSubscription- need to be using typedocuseReverification- need to be using typedoc (examples already done)Checklist