Skip to content

Commit fa5a8d7

Browse files
authored
fix: ensure event listeners are registered within service provider (Pod-Point#77)
* chore: add test for service provider event registration * fix: call register within event service provider
1 parent 7374691 commit fa5a8d7

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed

src/EventServiceProvider.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ class EventServiceProvider extends ServiceProvider
2020
*/
2121
public function register()
2222
{
23+
parent::register();
24+
2325
$this->registerSnsBroadcaster();
2426

2527
$this->registerSqsSnsQueueConnector();

tests/EventServiceProviderTest.php

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace PodPoint\AwsPubSub\Tests;
44

5+
use Illuminate\Support\Facades\Event;
56
use PodPoint\AwsPubSub\EventServiceProvider;
67

78
class EventServiceProviderTest extends TestCase
@@ -128,4 +129,23 @@ public function it_can_make_sure_some_aws_credentials_are_provided_and_valid(arr
128129
$this->assertArrayHasKey('foo', $config);
129130
$this->assertArrayNotHasKey('credentials', $config);
130131
}
132+
133+
/**
134+
* @test
135+
*/
136+
public function it_can_register_listeners_when_listen_array_is_populated()
137+
{
138+
$this->app->register(TestPubSubEventServiceProvider::class);
139+
140+
$this->assertCount(1, Event::getListeners('foo'));
141+
$this->assertCount(2, Event::getListeners('bar'));
142+
}
143+
}
144+
145+
class TestPubSubEventServiceProvider extends EventServiceProvider
146+
{
147+
protected $listen = [
148+
'foo' => ['bar'],
149+
'bar' => ['baz', 'qux'],
150+
];
131151
}

0 commit comments

Comments
 (0)