fix: ensure event listeners are registered within service provider #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oaklees
force-pushed
the
fix-event-listener-registration
branch
2 times, most recently
from
4d83b4e to
32781f7
Compare
oaklees
force-pushed
the
fix-event-listener-registration
branch
from
32781f7 to
f697a5f
Compare
clemblanco
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of Laravel 8, calling
parent::register()is required in anyEventServiceProviderclass that overridesregisterto ensure listeners get registered.See https://laravel.com/docs/8.x/upgrade#the-event-service-provider-class.
Test added and fix applied.