Optimize error message printing #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And allow the error message printing function to be configured by the user. In particular, stdio functions may not be safe to call if the user has called std::ios_base::sync_with_stdio(false) .
cjdb
reviewed
May 31, 2021
Owner
cjdb
left a comment
cjdb
left a comment
There was a problem hiding this comment.
Hey, thanks for working on this! Would you mind splitting this into separate PRs please? I'd prefer to have one commit for each of the logical changes.
Unless I'm missing something, this appears to be a bug in clang-tidy.
It seems to be confused by "if constexpr"
Contributor
Author
Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And allow the error message printing function to be configured by the user. In particular, stdio functions may not be safe to call if the user has called std::ios_base::sync_with_stdio(false) .