Change the sed code to also work on linux #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed -i only works on linux, and sed -i "" only works on OSX, but both linux and OSX can use perl to execute an in-place regex. (Any port in a storm, I suppose.) I also simplified the code to use find -exec instead of find -print0 | xargs.
felddy
approved these changes
Jul 6, 2019
Contributor
felddy
left a comment
felddy
left a comment
There was a problem hiding this comment.
Verified that this still works on the 🍎
Good improvement.
felddy
reviewed
Jul 6, 2019
| run( | ||
| f"find . \( ! -regex '.*/\.git/.*' \) -type f -exec " | ||
| f'perl -pi -e s/{parent_repo}/{new_repo}/g {{}} \;', | ||
| fr"find . \( ! -regex '.*/\.git/.*' \) -type f -exec " |
Contributor
There was a problem hiding this comment.
You know it's serious when the fr strings come out to play.
dav3r
approved these changes
Jul 8, 2019
Member
dav3r
left a comment
dav3r
left a comment
There was a problem hiding this comment.
The things we do to coexist... 👍 Nice changes.
dv4harr10
added a commit
that referenced
this pull request
Mar 4, 2024
Redo changes to formatting to reflect what the user should expect to see in terminal output.
jsf9k
pushed a commit
that referenced
this pull request
Mar 7, 2024
Redo changes to formatting to reflect what the user should expect to see in terminal output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sed -ionly works on linux, andsed -i ""only works on OSX, but both linux and OSX can useperlto execute an in-place regex. (Any port in a storm, I suppose.)I also simplified the code to use the simpler
find -execidiom, instead of the more complicatedfind -print0 | xargsidiom.