Skip to content

Enable to pass empty ArrayList in schemaless #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable to pass empty ArrayList in schemaless #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9a01c4
add IterableCodecProvider
jx2lee Sep 13, 2024
16262dd
unit test
jx2lee Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...in/java/com/github/cedelsb/kafka/connect/smt/converter/JsonSchemalessRecordConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.bson.codecs.DocumentCodecProvider;
import org.bson.codecs.MapCodecProvider;
import org.bson.codecs.ValueCodecProvider;
import org.bson.codecs.IterableCodecProvider;
import org.bson.codecs.configuration.CodecRegistries;
import org.bson.codecs.configuration.CodecRegistry;

Expand All @@ -36,7 +37,8 @@ public class JsonSchemalessRecordConverter implements RecordConverter {
new DocumentCodecProvider(),
new BsonValueCodecProvider(),
new ValueCodecProvider(),
new MapCodecProvider()
new MapCodecProvider(),
new IterableCodecProvider()
);

@Override
Expand Down
22 changes: 22 additions & 0 deletions src/test/java/com/github/cedelsb/kafka/connect/smt/Record2JsonStringConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,28 @@ public void transformRecordValue2JsonStringWithoutSchemaTest() {
assertEquals("{\"simpleString\": \"TestString\", \"simpleBoolean\": true, \"simpleFLOAT32\": 1.0, \"simpleFLOAT64\": 2.0, \"simpleInt8\": 8, \"simpleInt16\": 2, \"simpleInt32\": 3, \"simpleInt64\": 4, \"simpleBytes\": {\"$binary\": {\"base64\": \"S2Fma2Egcm9ja3Mh\", \"subType\": \"00\"}}, \"nestedArray1\": {\"entry\": \"testEntry\"}, \"nestedArray2\": {\"entry\": \"testEntry2\"}, \"simpleDate\": {\"$date\": \"2022-12-03T00:00:00Z\"}, \"simpleTime\": {\"$date\": \"2022-12-03T00:00:00Z\"}, \"simpleTimestamp\": {\"$date\": \"2022-12-03T12:00:00Z\"}, \"simpleDecimal\": {\"$numberDecimal\": \"12345.6789\"}}", jsonString);
}

@Test
public void transformRecordValue2JsonStringWithoutSchemaWithEmptyArrayListTest() {
// value for json format without schema
HashMap<String, Object> simpleValueWithoutSchema = new LinkedHashMap<>();
simpleValueWithoutSchema.put("emptyArrayList", new ArrayList<>());

final Map<String, Object> props = new HashMap<>();
props.put("json.string.field.name", "myawesomejsonstringfield");

valueSmt.configure(props);
final SinkRecord record = new SinkRecord(null, 0, null, null, null, simpleValueWithoutSchema, 0);
final SinkRecord transformedRecord = valueSmt.apply(record);

assertEquals(1, transformedRecord.valueSchema().fields().size());
assertEquals(Schema.STRING_SCHEMA,transformedRecord.valueSchema().field("myawesomejsonstringfield").schema());

Struct value = (Struct) transformedRecord.value();
String jsonString = (String) value.get("myawesomejsonstringfield");

assertEquals("{\"emptyArrayList\": []}", jsonString);
}

@Test
public void transformRecordValue2JsonStringLogicalTypesDatetimeAsStringTest() {
final Map<String, Object> props = new HashMap<>();
Expand Down