Make workerPids() work on Windows using WMIC instead of ps #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is WMIC available by default, or does it need to be installed separately? Though it would certainly be nice to not have to use |
Contributor
Author
|
WMIC is installed by default. Agreed that it'd be nice not to use exec(). It just occurred to me that my Windows worker code depends on an ugly hack: Because Windows does not provide process forking, Windows workers won't run without changing Worker.php:190 to "if (true)" to run as the child. It's orthogonal to this patch, but Windows workers won't run without it. I'll try to make that less hackish and submit a patch. |
Contributor
Author
|
Closing this because it's essentially the same as #93. I took a few iterations to get there but the result is the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec('ps...') fails on Windows -- switch to equivalent Windows command