Skip to content

Conversation

@varvar
Copy link

@varvar varvar commented Dec 31, 2015

HI, I've added a method which can retrieve all the items of a list. For example : all failed queues

@danhunsaker
Copy link
Contributor

I'd do a couple of things to this before expecting a merge. First, most of the Resque methods have more descriptive names than the underlying Redis command, so I'd change the method name to something else that reflects its purpose rather than its internals. Second, I'd make the second two arguments optional, and default them to retrieve the full list. This will increase the added value of such a function.

@danhunsaker
Copy link
Contributor

Other than that, though (and the coding style - spaces between function arguments, please), it looks good here!

danhunsaker added a commit to resque/php-resque that referenced this pull request Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants