Skip to content

[ClickHouse–Iceberg] Fix performance issue in decimal bounds processing for integer decimals #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ClickHouse–Iceberg] Fix performance issue in decimal bounds processing for integer decimals #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Storages/ObjectStorage/DataLakes/Iceberg/ManifestFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ namespace
/// To handle this issue we subtract 1 from the integral part for lower_bound and add 1 to integral
/// part of upper_bound. This produces: 17.22 -> [16.0, 18.0]. So this is more rough boundary,
/// but at least it doesn't lead to incorrect results.
{
if (int32_t scale = DB::getDecimalScale(*non_nullable_type)){
int64_t scaler = lower_bound ? -10 : 10;
int32_t scale = DB::getDecimalScale(*non_nullable_type);
while (--scale)
scaler *= 10;

Expand Down
Loading