feat: refine call states #7179
Merged
feat: refine call states #7179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/refine-call-states
branch
9 times, most recently
from
7c85bea to
79b7b34
Compare
- sync declined calls from callee to caller, as usualy in all larger messengers - introduce the call states "Missed call", "Declined call" and "Cancelled all" - allow calling end_call()/accept_call() for already ended/accepted calls, in practise, handling all cornercases is tricky in UI - and the state needs anyways to be tracked.
r10s
force-pushed
the
r10s/refine-call-states
branch
from
79b7b34 to
0677d70
Compare
r10s
force-pushed
the
r10s/refine-call-states
branch
from
8cf9295 to
7d42e6b
Compare
adbenitez
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the duration calculation depends on local time, but it is displayed only coarse and is not needed for any state. this can be improved as needed, timestamps of the corresponding messages are probably better at some point. or ending device sends its view of the time around. but for the first throw, it seems good enough
if we finally want that set of states, it can be exposed to a json-info in a subsequent call, so that the UI can render it more nicely. fallback strings as follows will stay for now to make adaption in other UI easy, and for debugging:
successor of #6650