fix: do not reverify already verified contacts via gossip #7113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/qxpwvyszponl
branch
from
de2d963 to
cd778ad
Compare
Hocuri
approved these changes
Aug 14, 2025
If the contact is already introduced by someone, usually by adding to a verified group, it should not be reverified because of another chat message is a verified group. This usually results is verification loops and is not meaningful because the verifier likely got this same contact introduced in the same group.
link2xt
force-pushed
the
link2xt/qxpwvyszponl
branch
from
cd778ad to
4acbaf4
Compare
|
Quite bad bug. Now the verification chain/history is lost for many users. |
|
Seems it also overwrote existing direct verifications with non-direct verifications. |
|
In #7111 "Expire the verification-property of QR codes", the last point is:
This will then solve the problem of the lost (and in many cases, wrong/circular) verification chain. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the contact is already introduced by someone,
usually by adding to a verified group,
it should not be reverified because of another
chat message is a verified group.
This usually results is verification loops
and is not meaningful because the verifier
likely got this same contact introduced
in the same group.
Closes #7107