fix: Add query to post request for account creation #6989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds that the given request url is requested instead of only the path. This fixes the newly added test. close #6988
Septias
changed the title
|
This looks good, but I'd remove the test. It's unfortunate that it's not possible to have automated test for this, but otherwise it creates a new account on mailcow every time we run it and the test will start failing when the token is invalidated.
Just a sidenote, deltachat-repl can be used for this sort of manual testing without building the whole client. |
|
I will squash-merge it now without a test so it goes into the next core release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds that the given request url is requested instead of only the path. This fixes the newly added test.
Testing: tried to to test it locally but because of nix, I cant run electron or tauri.. ._.
close #6988