fix: explicitly close the database on account removal #5814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested in #5811, this actually fixed the problem. CI passed on Windows without |
This was referenced Jul 29, 2024
iequidoo
approved these changes
Jul 29, 2024
WofWca
added a commit
that referenced
this pull request
Apr 17, 2025
If 5 times is not enough, 60 will probably not be enough either. This is mainly an attempt of improving the situation with deltachat/deltachat-desktop#3959. The `remove_account` RPC call would make the RPC server stop responding to all other requests, which is basically equivalent to a one minute hang. Additionally, `try_many_times` appears to be unnecessary after #5814 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5809