test: wait for joiner success in test_verified_group_[member_added]_recovery #5191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/fix-flaky-securejoin-tests
branch
from
5a8c27e to
0d2c578
Compare
iequidoo
approved these changes
Jan 18, 2024
|
This still managed to fail the tests, will look into it. |
…ecovery If we wait for inviter success, vg-member-added message may be still in flight and reach ac2 after device resetup. Making ac2 wait for joining the group ensures that old device receives vg-member-added message and new device will not receive it and fail to decrypt. Other instances of wait_for_securejoin_inviter_success() in the same tests are also replaced for reliability.
link2xt
force-pushed
the
link2xt/fix-flaky-securejoin-tests
branch
from
0d2c578 to
86079ef
Compare
|
Added skipping member added, now should work. |
iequidoo
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we wait for inviter success,
vg-member-added message may be still in flight
and reach ac2 after device resetup.
Making ac2 wait for joining the group ensures that old device receives vg-member-added message
and new device will not receive it and fail to decrypt.
Other instances of wait_for_securejoin_inviter_success() in the same tests are also replaced for reliability.
Fixes #5189